kicad-developers team mailing list archive

[Jeff Young <jeff@xxxxxxxxx>]

Hi JP,

The main reason I don’t favour the 2-control solution is that you want to see the results of the filter as you type.  We could do that with a textbox and a listbox, but that takes up more space (which would be an issue in Pad Properties).

Equally important is probably that I’m stubborn. ;)

One more re-write is up.  This one turns the popup into a wxSTAY_ON_TOP wxDialog and uses an EventFilter rather than its own eventLoop.

Cheers,
Jeff.


> On 26 Sep 2018, at 08:55, jp charras <jp.charras@xxxxxxxxxx> wrote:
> 
> Le 25/09/2018 à 18:57, Jeff Young a écrit :
>> Thanks, JP.  I’ve pushed another “fix”.  It works on OSX, but then so did the first one, so who knows.
>> 
>> Let me know how it works on Linux & MSW.
>> 
>> Cheers,
>> Jeff.
> 
> Hi, Jeff,
> 
> The net selector now shows the list of nets, but it does not really work:
> - There are some artifacts on screen (drop down list not very well redrawn)
> - Some nets are not selectable (depending on the widget behind the list)
> - the net filter does not work.
> - When closing the dialog, sometimes the mouse events are no longer
> captured by the GAL canvas (until the mouse is moved out and then in the
> canvas area): it happens to me when closing the drop down list and then
> the dialog by the return key.
> 
> Why do not use a basic wxChoice to list and choose the nets, associated
> to a wxTextCtrl to enter a net filter pattern?
> 
> It should work easily on any platform.
> 
>> 
>> 
>> 
>>> On 25 Sep 2018, at 16:38, jp charras <jp.charras@xxxxxxxxxx> wrote:
>>> 
>>> Le 25/09/2018 à 16:09, Jeff Young a écrit :
>>>> OK, so it looks correct, it’s just closing itself immediately.
>>>> 
>>>> @JP or @Wayne,
>>>> 
>>>> Could one of you put a breakpoint in NET_SELECTOR_POPUP::DoPopup() (in
>>>> net_selector.cpp somewhere around line 134) and see why it’s exiting?
>>>> 
>>>> Thanks,
>>>> Jeff.
>>>> 
>>> 
>>> the loop:
>>> while( eventLoop.Pending() )
>>> is made only once, due to the fact eventLoop.Pending() is true only once.
>>> 
>>> -- 
>>> Jean-Pierre CHARRAS
>>> 
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>> 
>> 
> 
> 
> -- 
> Jean-Pierre CHARRAS
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>