kicad-developers team mailing list archive

[John Beard <john.j.beard@xxxxxxxxx>]

Hi all,

There's also (groan) an MSVC failure here. The includes for the file
in the new qa_utils lib aren't picked up, so it fails. The includes
*are* in my Linux build and are evidently also in the Mac/Mingw builds
as they work too. Could this be related to the top-level CMakeLists,
which goes "tools, utils, qa", but "tools/io_benchmark" relies on
"qa/qa_utils"?

In which case does flipping the CMake add_subdirectory order work
(attached patch).

If this *does* work, any clues as to why only MSVC cares?

Would it be better to put io_benchmark in to the qa folder anyway?

Cheers,

John
On Wed, Oct 24, 2018 at 12:20 AM Adam Wolf
<adamwolf@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> The Mac build was broken last night, a rebuild this morning didn't help, but I'll trigger another one now and see how it goes.
>
> Thanks folks!
>
> On Tue, Oct 23, 2018, 5:44 PM Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>
>> Fixes the linux build.  Yeah!!
>>
>> On 10/23/18 6:37 PM, Seth Hillbrand wrote:
>> > Am 2018-10-23 17:48, schrieb Jeff Young:
>> >>> … Let's just hope the macos build doesn't choke.
>> >>
>> >> He he.  And it did. :)
>> >>
>> >> I think I fixed it but someone might want to check that I didn’t do
>> >> something stupid.
>> >>
>> >> https://git.launchpad.net/kicad/commit/?id=4061f1cce3b177ceca894fd2f01e0eedd928273b
>> >>
>> >
>> > Just needed a little tweak
>> >
>> > Best-
>> > Seth
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

From 13c837029bbb860c181de7546beb04592ef3c524 Mon Sep 17 00:00:00 2001
From: John Beard <john.j.beard@xxxxxxxxx>
Date: Wed, 24 Oct 2018 12:37:54 +0100
Subject: [PATCH] CMake: tools after qa

tools/io_benchmark needs qa/qa_utils
---
 CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index cf55d49e7..fd15d44d6 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -976,9 +976,9 @@ add_subdirectory( bitmap2component )
 add_subdirectory( pcb_calculator )
 add_subdirectory( plugins )             # 3D plugins must be built before kicad
 add_subdirectory( kicad )               # should follow pcbnew, eeschema
-add_subdirectory( tools )
 add_subdirectory( utils )
 add_subdirectory( qa )
+add_subdirectory( tools )               # needs qa_utils
 
 # Resources
 if ( KICAD_INSTALL_DEMOS )
-- 
2.19.0