← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 2/3] Fix line endings in pcb_calculator_frame_base.fbp


On 3/19/2019 11:32 AM, Kevin Cozens wrote:
> On 2019-03-19 11:06 a.m., Wayne Stambaugh wrote:
>> I wasn't aware we were converting all wxFormbuilder file line endings to
>> unix.  I was under the impression that git could handle either
> Typical use is to use unix line endings in the repository and use the
> autocrlf feature of git to change the line endings to the native format
> on checkout. The line endings will be saved in unix standard on file
> checkin.

This requires every user to manually set core.autocrlf correctly in
their global git configuration.  If someone forgets, then dos line
endings could get committed.  There is no .gitattribute file in the
kicad source to override the users default setting.  Maybe we should add
this so developers do not have to change their global settings.