kicad-developers team mailing list archive

[Jeff Young <jeff@xxxxxxxxx>]

Hi Michael,

I’ve removed a bunch of the disabling on purpose.  Some of them serve a purpose (such as undo/redo telling you when you’re at the start or end of the stack).  Most of them are just noise in the UI.

Could you log a bug for the icon scale thing?  That’s not something I know how to fix at present.

Cheers,
Jeff.


> On 15 May 2019, at 19:09, Michael Kavanagh <michael@xxxxxxxxxxxxxxxxxx> wrote:
> 
> Hi Jeff,
> 
> This is great! A few comments:
> The icon scale doesn't seem to work
> Eeschema: Leave sheet button is always enabled.
> Libedit: the arc and polyline tools have the circle tool icon. Also these aren't disabled when there's no symbol loaded on startup.
> Cheers.
> Michael
> 
> On Wed, 15 May 2019 at 18:32, Jeff Young <jeff@xxxxxxxxx <mailto:jeff@xxxxxxxxx>> wrote:
> This is probably a good time for a few words about the new code.
> 
> CONDITIONAL_MENU (which we used to use just for context menus) has been expanded to also work in the main menu bar.  You can insert either ACTIONs or wxWidgets’ style IDs into it.  In either case, you no longer need UpdateUI event handlers as the conditions handle that.  This allows for much improved encapsulation (and wxWidgets isolation, for what that’s worth).
> 
> There is also now ACTION_TOOLBAR, which is more-or-less an equivalent for toolbars.  However, it doesn’t handle conditionals as toolbars have to be kept up-to-date at all times due to their visibility.  The modern toolset already provided SyncMenusAndToolbars() for this (so we still get improved encapsulation).  We could probably rename that to SyncToolbars(), though, as it no longer needs to do the menus.
> 
> Cheers,
> Jeff.
> 
> 
>> On 15 May 2019, at 18:13, Jeff Young <jeff@xxxxxxxxx <mailto:jeff@xxxxxxxxx>> wrote:
>> 
>> I’ve just pushed new bits.  I don’t have any expectation that they’ll fix this, but they do make changes in that area so they might.
>> 
>> Oh, wait, you guys are just seeing this in PCBNew?  In that case I do think my new bits will fix it.  (The call to evaluate the conditions wasn’t getting caught.)
>> 
>> However, Art and Laurent also reported it in Eeschema, which I can’t explain.
>> 
>> Cheers,
>> Jeff.
>> 
>> 
>>> On 15 May 2019, at 18:10, Jeff Young <jeff@xxxxxxxxx <mailto:jeff@xxxxxxxxx>> wrote:
>>> 
>>> I haven’t seen this on OSX, but Art and Laurent have reported it on MSW.
>>> 
>>>> On 15 May 2019, at 17:46, Jon Evans <jon@xxxxxxxxxxxxx <mailto:jon@xxxxxxxxxxxxx>> wrote:
>>>> 
>>>> I just checked, I see the same problem, Ubuntu / GTK3 (interesting that it works for you, JP)
>>>> 
>>>> On Wed, May 15, 2019 at 12:44 PM jp charras <jp.charras@xxxxxxxxxx <mailto:jp.charras@xxxxxxxxxx>> wrote:
>>>> Is it just me, or it affects some other users?
>>>> 
>>>> Since changes in commit ef5c69167, in Pcbnew, Linux Ubuntu / GTK2 (right
>>>> mouse click) is not displayed:
>>>> 
>>>> on Windows and Linux Ubuntu / GTK2 it is displayed only when the "Route
>>>> track" tool is active.
>>>> 
>>>> On Linux/ GTK2 a small rect is shown, like a empty popup menu.
>>>> 
>>>> However on Linux Ubuntu / GTK3 the context menu is always displayed.
>>>> 
>>>> Other applications work fine.
>>>> 
>>>> -- 
>>>> Jean-Pierre CHARRAS
>>>> 
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>>> 
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
>> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers <https://launchpad.net/~kicad-developers>
> More help   : https://help.launchpad.net/ListHelp <https://help.launchpad.net/ListHelp>