kicad-developers team mailing list archive

[Seth Hillbrand <seth@xxxxxxxxxxxxx>]

On 2019-05-28 12:13, Tomasz Wlostowski wrote:
> Done (tom-crash-reporter-may27 on my Github)!
>
> Tom

Hi Tom-

This looks very nice.  I like the implementation a lot!

Here are a couple minor bits:

1) The force crash dialog says "Clicking on OK will crash KiCad" but the 
buttons say "Yes/No"
2) The crash report doesn't seem to pick up my build version 
information.  It says:

KiCad crash report, version 1.0
--------------------------------------------------

application: kicad
version:     , release build

3) The tabbing changes in CMakeLists.txt are odd.  Intentional?
4) There's an untranslated string in OnSendReport ("Error sending cebug 
report.")[sic]


No showstopper issues from my testing here.  I'd like to implement a 
configurable destination address (maybe preferences or environmental 
variable) but that can wait until after it's merged.

Thanks Tom (and Thomas) for an excellent addition!

Best-
Seth