← Back to team overview

kicad-developers team mailing list archive

Re: [Patch] Hotkey validation/checking for 5.1



I merged your patch into the 5.1 branch.  Thank you for your
contribution to KiCad.

I'm not sure a check on start up is necessary.  Your solution gives the
user clear warning about duplicate and invalid hotkeys in the
preferences dialog.  If you do decide to add a warning on start up,
please make it possible to never show it again.



On 6/11/19 12:47 PM, Ian McInerney wrote:
> Attached is a patch that adds in hotkey validation/checking to the 5.1
> branch. This will display error messages with the hotkeys when the user
> edits the hotkeys, and notifies the user that there are invalid hotkeys
> when viewing the list. It also checks imported files for their validity,
> and warns the user when errors are found.
> Currently, it does not check on startup of the program. It will only
> check when a user is already editing/viewing the hotkeys. The only time
> this actively prevents the user from doing something is when they enter
> an invalid hotkey when changing a hotkey, other than that it is a
> notification system.
> I have been on the fence about adding a startup check of the hotkeys
> that will then direct the user to the preferences menu to fix them, but
> in 5.1 that would be so scattered it would be somewhat painful to do it
> nicely.
> This does not apply to the master branch currently, since Jeff just
> pushed the start of the hotkey infrastructure rework to it. Eventually I
> do want to add this to master, but I need to analyze his changes first
> and figure out the best way of implementing it on the new framework.
> -Ian
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp