← Back to team overview

kicad-developers team mailing list archive

Fix in LIB_LOGGER to avoid Kicad crash on exit. Need review.


Hi Jeff,

Could you have a look into my commit 9259f3a7.

It fixes a crash on Windows on Kicad exit, if libedit was opened during
a session.

I am thinking it was due to the fact wxLog::SetActiveTarget( this ) was
called, but after deleting libedit (and therefore the created LIB_LOGGER
) wxLog was pointing a deleted LIB_LOGGER
(wxLog::SetActiveTarget( m_previousLogger ) is never called if no error

I am thinking my code works, but I need your opinion, because this is
your code and I am not specialist of wxLog.


Jean-Pierre CHARRAS

Follow ups