kicad-developers team mailing list archive

[Jeff Young <jeff@xxxxxxxxx>]

Hi Seth,

We weren’t calling it directly anywhere.  But jtMiter has a MiterLimit, after which it falls back to square.  I’ve changed that fallback to round (and enforced a much lower MiterLimit so that it mimics the smoothing we used to get by drawing the border with a 1/2-min-width thick stroke).

Cheers,
Jeff.

> On 14 Jul 2019, at 17:50, Seth Hillbrand <seth@xxxxxxxxxxxxx> wrote:
> 
> On 2019-07-14 05:31, Jeff Young wrote:
>> I made another optimisation, this time within the Clipper library.
>> When the offset exceeds the MiterLimit it will perform jtRound instead
>> of jtSquare.  I *think* this makes the zero-width-border algorithm
>> materially indistinguishable from the old algorithm (well, except that
>> several bugs are fixed in the new one and it’s faster).
> 
> Hi Jeff-
> 
> Were we using jtSquare somewhere?  I had added an option to inflate using jtMiter but this was for Eagle import only.  I thought all other inflations were using jtRound.
> 
> Best-
> Seth