← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH v2 0/8] MSVC Build



On 7/12/2019 4:00 PM, Simon Richter wrote:
> Hi Wayne,
>> I have to apply the patches, build, and test.  I should be able to get
>> to it over the weekend.  My only comment is on patch #1.  I would have
>> preferred that we implemented the missing boost pointer container object
>> clone methods rather the work around.  As a temporary fix I could live
>> with this but it just feels wrong to me.
> I'm not even sure it is wrong -- if I understood the problem correctly,
> we'd do a deep clone of a container containing objects, and then throw away
> the original, so we could just return the original instead.

It's not so much wrong in that it is likely to cause issues if someone
wants to make a deep copy of these object types without manipulating the
original copy.  I'm surprised this hasn't bit anyone before now.  I
suppose we could use a different container if we are never going to make
copies of the objects.  The boost pointer containers are somewhat
predicated on the fact that the clone operator will be provided in order
for the template to be complete.

>>  Everything else seems pretty
>> straight forward.  I definitely want to get some testing due to the
>> changes to make sure nothing is broken before we cherry pick this to the
>> 5.1 branch.
> I haven't tested this on 5.1 yet, because I was expecting this to go into
> master only.

I was working under the assumption that devs would want to build the 5.1
branch with msvc but I have no problems with making this v6 and later.


>    Simon
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp