kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #42162
Re: Context menu & immediate actions
Ian,
On 10/3/2019 1:53 PM, Ian McInerney wrote:
> Wayne,
>
> Part of why I asked this is because in Eechema the context menu has the
> wire/bus tools (so you can start drawing a wire/bus) normally, but when
> you actually right-click on a pin location those tools aren't in the
> context menu. So it seemed weird to me to want to start drawing
> everywhere other than where a wire would normally start. Perhaps this is
> more of a bug with that menu though.
The action should definitely begin at the mouse right click position.
>
> I know right now we have the option to turn off the immediate nature of
> the hotkey&menus at once (although it doesn't seem to actually have any
> effect on the hotkeys on the context menu, so I will look into that
> bug), but would you be open to having the option to turn off the
> immediate nature of the menus separate from the hotkeys?
I'm fine with this but it should default to the same behavior as the
default hotkey behavior (immediate) to prevent confusion.
>
> -Ian
>
> On Thu, Oct 3, 2019 at 1:44 AM Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
>
> Ian,
>
> Context menus should behave the same as hotkeys at the canvas position
> where the context menu was opened (right clicked). In the legacy
> canvas, this was the default behavior. For the most part, the old
> hotkey handler would send the equivalent context menu command event and
> execute the same code path as the context menu command event. If this
> has changed, I would consider it a bug. Context menu and main frame
> menu command events are not the same thing and should not be treated as
> such.
>
> Wayne
>
> On 10/2/19 5:19 PM, Ian McInerney wrote:
> > I was noticing some odd behavior with the zone tool in the master
> branch
> > just now, specifically when you run an action of its through the
> context
> > menu (such as add zone cutout). When you select the menu item, it will
> > begin drawing immediately, which on my Linux box causes some weird
> > behavior (it will place the first point in the location where the
> > context menu item was located and then move the cursor back to
> where the
> > menu originated, creating a line segment).
> >
> > The thing that confused me was the fact that it was trying to do an
> > immediate action here. Isn't the policy to have the immediate actions
> > triggered by the hotkeys and for the menus to just load the tool
> so the
> > user can just click to start it? I know that is how the menubar
> > menus/toolbars operate, so I had thought that was also how the context
> > menus were supposed to operate for these drawing commands as well.
> >
> > -Ian
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
References