kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Use the clang-format git commit hook[1] to only format the changes in
your git commits rather than entire files.

[1]:
http://docs.kicad-pcb.org/doxygen/md_Documentation_development_coding-style-policy.html#tools

On 10/15/19 4:22 PM, Zficani Zficani wrote:
> HI,
> thank you so much for the feedback. 
> I agree with your first point, will do that very soon. 
> Regarding the code formatting, I tried using both uncrustify and
> clang-format with the supplied configs but none of them really worked
> because they would end up changing lots of other code outside of the
> scope of this feature so I'm not sure what to do about that (even just
> other parts of files I edited). I could always do this by hand but
> automagic code formatting is much nicer.
> I suspected there may be some issues with multi-unit symbols so I will
> look into that. 
> I will also use `format-patch` when sending in new patches. Thank you
> for letting me know about it.  
> 
> On Tue, Oct 15, 2019 at 8:41 PM Seth Hillbrand <seth@xxxxxxxxxxxxx
> <mailto:seth@xxxxxxxxxxxxx>> wrote:
> 
>     On 2019-10-14 14:42, Zficani Zficani wrote:
> 
>     > Hi,
>     > No problem, I just wanted to make sure I sent the message properly.
>     > Here's a single squashed patch with all previous changes and these
>     > comments about copying selection.
>     >
>     > Thank you so much for your review.
>     >
> 
>     Hi Zficani-
> 
>     The functionality feels correct and I really like it.  Here are a few
>     comments on the current patch:
> 
>     1) I would prefer that the disabled options in the Annotation page are
>     grey (disabled) and not hidden when the option is unchecked.  This
>     reserves the correct space for them when we add options in the future.
> 
>     2) Please double-check your code formatting.  Spaces inside the
>     parentheses are missing in a few spots.
> 
>     3) Don't use C-style casts.  C++ static_cast<type>() is preferred.
> 
>     4) Single-line statements after if/else don't get brackets {}
> 
>     5) I think that pasting Unit B of a component should paste as the first
>     missing Unit B in the schematic and not the next open annotation
>     number.
>       See the attached image for the result of duplicating a quad op-amp
>     for
>     an example of this problem.
> 
>     This will be a great addition to KiCad.  Thank you for taking this one
>     on!
> 
>     Best-
>     Seth
> 
>     Seth Hillbrand
>     KiCad Services Corporation
>     +1 530 302 5483 | +1 212 603 9372
>     www.kipro-pcb.com <http://www.kipro-pcb.com>
>     Davis, CA
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>