← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH v2] eeschema: Allow hierarchy navigator to stay open


Le lun. 4 nov. 2019 à 13:19, Wayne Stambaugh <stambaughw@xxxxxxxxx> a écrit :
> Hi Franck,
> There is a memory leak with your code.  The Destroy() method is never
> called when the hierarchy navigation dialog is closed.  When using
> modeless dialogs, you are responsible for cleaning up the dialog created
> on the heap.  The schematic editor Find/Replace dialog is modeless so
> you can use that as an example of how to handle modeless dialogs.
> Cheers,
> Wayne

Hi Wayne,

Good catch. Thanks for the review.
I'll do a v3 when I have some time.