← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Pcbnew drill sizes statistics & Project manager multiple selection options


Le 11/11/2019 à 01:04, Mikołaj Wielgus a écrit :
> - Pcbnew drill sizes statistics:
> I've modified the filter and also made the last two columns expand to
> fit the remaining space during grid creation and window resizing.
> As for the column sizes: they are assigned with the wxGrid::AutoSize()
> method built-into WxWidgets. Because of that, I'm reluctant to add any
> arbitrary values to the column sizes. Also, it's not uncommon for column
> widths to be partially concealed in GUI applications (they sometimes
> take a lot more space than the table values themselves). The grid is
> resizable, so if the user wants to check the label, they will be able to
> resize it easily.
> Furthermore, on my operating system, I don't have my column labels
> concealed when sorted.
> Because of this, I think it will be better if you tweak the column
> widths yourself to make them work as desired in your environment (if you
> aren't convinced by my argument). This can be done easily by iterating
> over all columns and adding a constant to each one's width right after
> the m_gridDrills->AutoSize(); line.
> Please let me know if you have any better idea how to address this.
> Best Regards,
> Mikołaj Wielgus

Hi Mikołaj,

Thanks for your contribution.

I committed your patch (with a minor change to avoid a wxWidgets alert).

AFAIK, we always have some issues with column sizing in wxGrid
(depending on the platform and wxWidgets version)

In this case, this sizing problem is a minor issue.

> On Thu, Nov 7, 2019 at 3:37 PM jp charras <jp.charras@xxxxxxxxxx
> <mailto:jp.charras@xxxxxxxxxx>> wrote:
>     Le 06/11/2019 à 23:18, Mikołaj Wielgus a écrit :
>     > Hello,
>     >
>     > I have submitted two patches on Launchpad some time ago. I would
>     like to
>     > ask for feedback.
>     >
>     > Links:
>     > https://bugs.launchpad.net/kicad/+bug/1841144
>     > https://bugs.launchpad.net/kicad/+bug/1016464
>     >
>     > Best Regards,
>     > Mikołaj Wielgus
>     Hi Mikołaj,
>     First, thanks for your contribution.
>     I had a look into your patches.
>     I do not seen big problems, but I suggest a few enhancements:
>     -  Project manager multiple selection options:
>     When deleting a list of files, a confirmation is asked for each file.
>     Only one confirmation is enough.
>     When deleting a list of files, a instance of the editor is opened for
>     each file.
>     All editors are able to open more than one file, so I suggest only one
>     instance of the editor opening all files.
>     - Pcbnew drill sizes statistics:
>     It display pads with no holes. The filter to select pads:
>     if( pad->GetAttribute() != PAD_ATTRIB_SMD )
>     is incorrect
>     (other pads can have no hole).
>     the filter must test only the hole size.
>     A minor cosmetic issue:
>     The columns sizes are too small:
>     When sorting a column, the column label is not readable (see X size
>     column in attached files).
>     They are minor issues.
>     Can you fix them.
>     Thanks.
>     -- 
>     Jean-Pierre CHARRAS
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     More help   : https://help.launchpad.net/ListHelp

Jean-Pierre CHARRAS

Follow ups