kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 11/11/2019 à 01:12, Ian McInerney a écrit :
> JP,
> 
> Are you running this on your 3.0 or 3.1 build of wxwidgets? That looks
> like there is an issue with their autosize calculation not factoring in
> the width of the sorting bitmap.
> 
> -Ian
> 

I am using wxWidgets 3.1.3 currently.

(I sometimes rebuild Kicad with wxPython on wxWidgets 3.0.4, for tests)


> On Thu, 7 Nov 2019, 14:37 jp charras, <jp.charras@xxxxxxxxxx
> <mailto:jp.charras@xxxxxxxxxx>> wrote:
> 
>     Le 06/11/2019 à 23:18, Mikołaj Wielgus a écrit :
>     > Hello,
>     >
>     > I have submitted two patches on Launchpad some time ago. I would
>     like to
>     > ask for feedback.
>     >
>     > Links:
>     > https://bugs.launchpad.net/kicad/+bug/1841144
>     > https://bugs.launchpad.net/kicad/+bug/1016464
>     >
>     > Best Regards,
>     > Mikołaj Wielgus
> 
>     Hi Mikołaj,
> 
>     First, thanks for your contribution.
> 
>     I had a look into your patches.
> 
>     I do not seen big problems, but I suggest a few enhancements:
>     -  Project manager multiple selection options:
>     When deleting a list of files, a confirmation is asked for each file.
>     Only one confirmation is enough.
>     When deleting a list of files, a instance of the editor is opened for
>     each file.
>     All editors are able to open more than one file, so I suggest only one
>     instance of the editor opening all files.
> 
>     - Pcbnew drill sizes statistics:
>     It display pads with no holes. The filter to select pads:
>     if( pad->GetAttribute() != PAD_ATTRIB_SMD )
>     is incorrect
>     (other pads can have no hole).
>     the filter must test only the hole size.
>     A minor cosmetic issue:
>     The columns sizes are too small:
>     When sorting a column, the column label is not readable (see X size
>     column in attached files).
> 
>     They are minor issues.
>     Can you fix them.
> 
>     Thanks.
> 
> 
>     -- 
>     Jean-Pierre CHARRAS
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     More help   : https://help.launchpad.net/ListHelp
> 


-- 
Jean-Pierre CHARRAS