kicad-developers team mailing list archive

[Seth Hillbrand <seth@xxxxxxxxxxxxx>]

On 2019-11-16 11:03, Steven A. Falco wrote:
> On 11/16/19 1:14 PM, Seth Hillbrand wrote:
> > On 2019-11-16 08:42, Steven A. Falco wrote:
> > > It looks like Fedora may be switching from OCE to OCC, so I'm doing a
> > > trial build with OCC.
> > >
> > > How would folks recommend testing the build?  I'm not sure what would
> > > be necessary.
> > >
> > >
> > > Also, I have a question about CMakeLists.txt.  Around line 91, it 
> > > says:
> > >
> > > option( KICAD_USE_OCC
> > >     "Build tools and plugins related to OpenCascade Technology
> > > (overrides KICAD_USE_OCE, default OFF)"
> > >     OFF )
> > >
> > > Note the comment that says KICAD_USE_OCC will override KICAD_USE_OCE.
> > > Thus, one would think that just setting KICAD_USE_OCC=ON would be
> > > sufficient to automatically set KICAD_USE_OCE=OFF
> > >
> > > Also, the code at line 472 makes it look like setting 
> > > KICAD_USE_OCC=ON
> > > would set KICAD_USE_OCE=OFF.  However, in my build, that didn't work,
> > > and I had to explicitly set KICAD_USE_OCE=OFF.
> > >
> > >     Steve
> >
> > Thanks Steve!  I'm very happy to hear that Fedora is switching.
> >
> > I pushed a fix for the issue you've identified.
>
> Thanks Seth - that was fast!  I confirm that the fix is good.  I can
> now build with just setting KICAD_USE_OCC=ON.
>
> I tried opening a 3-d view of a board, and it loaded correctly.  Is
> that a sufficient test for OCC or is there more that I should try?
>
> 	Steve

3d view will check that we import models correctly.  I would suggest the 
additional tests:

- Exporting the demo boards to STEP files.
- Importing a mix of STEP and IGES models into a board
- Be sure to check exports of boards with cut out holes in the middle
- Check boards with arcs on the edge.cuts
- Check boards with circles on the edge.cuts

-Seth

Seth Hillbrand
KiCad Services Corporation
https://www.kipro-pcb.com
+1 530 302 5483 | +1 212 603 9372