← Back to team overview

kicad-developers team mailing list archive

Fix lp:1849376



Here attached you'll find a patch to correct issue 1849376 on launchpad.
When a component is placed, action addNeededJunctions is now triggered.

If some of you have some spare time, I also have two branches with
patches you can review and/or test. The first allows the hierarchy
navigator to stay open:


The second branch as a patch adding a function to insert intersheets
references attached to global labels:


Thanks in advance.

From 6e2788c5153eaab4e312decd361b4fa9914b1eb5 Mon Sep 17 00:00:00 2001
From: Franck Jullien <franck.jullien@xxxxxxxxx>
Date: Tue, 26 Nov 2019 22:03:19 +0100
Subject: [PATCH] eechema: add junction if needed when component is placed

Fixes: lp:1849376
* https://bugs.launchpad.net/kicad/+bug/1849376
 eeschema/tools/sch_drawing_tools.cpp | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/eeschema/tools/sch_drawing_tools.cpp b/eeschema/tools/sch_drawing_tools.cpp
index 05d6a0a04..35a3db363 100644
--- a/eeschema/tools/sch_drawing_tools.cpp
+++ b/eeschema/tools/sch_drawing_tools.cpp
@@ -191,6 +191,9 @@ int SCH_DRAWING_TOOLS::PlaceComponent(  const TOOL_EVENT& aEvent  )
                 m_frame->AddItemToScreenAndUndoList( component );
+                m_toolMgr->RunAction( EE_ACTIONS::addNeededJunctions, true, component );
+                m_frame->OnModify();
                 if( m_frame->GetUseAllUnits() || m_frame->GetRepeatComponent() )
                     int new_unit = component->GetUnit();

Follow ups