kicad-developers team mailing list archive

[Jon Evans <jon@xxxxxxxxxxxxx>]

In lib_id.h, LIB_ID::Test() is declared inside "#if defined(DEBUG)"

But in lib_id.cpp, LIB_ID::Test() will never be implemented because it is
wrapped in:
#if 0 && defined(DEBUG)

I have no idea the history of this (git blames you, Wayne), but this seems
like it would create linker errors for sure.

Do we even need that stuff?  Can we delete it?  If not, I guess we should
change the header to "#if 0 && defined(DEBUG)" also.

On Fri, Feb 7, 2020 at 1:55 PM Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:

> I tried commenting out line 404 in pcbnew/CMakeList:
>
> #        -I${WXPYTHON_SWIG_DIR}
>
> but that didn't help either.
>
> On 2/7/20 1:42 PM, Simon Richter wrote:
> > Hi,
> >
> > On 07.02.20 19:31, Jon Evans wrote:
> >
> >> Good find!  I think we should remove that line
> >> (pcbnew/CMakeLists.txt:403) since it's not used.
> >> I guess we have just been clobbering KICAD_CONFIG_DIR for swig and it
> >> just didn't matter.
> >
> > Yes, that should be done for the sake of cleanup.
> >
> > The other thing is that this does not solve the problem. I just did a
> > full rebuild and WTF.
> >
> >    Simon
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>