kicad-developers team mailing list archive

[Ian McInerney <Ian.S.McInerney@xxxxxxxx>]

> 1) "Save" is not activated in the toolbar. It's activated in the File
menu. But when I click on the canvas, the button is activated.

This is going to be due to how the toolbar and menu states are updated. The
menus are CONDITIONAL_MENUS which rebuild whenever they are opened, but the
toolbars are synced by the tool framework explicitly on some actions. This
will get cleaned up when I switch over to the EVT_UPDATE_UI system and
remove the SyncToolbars function. In the meantime, please file this as an
issue with v6 milestone and I can assign myself and link it to the
appropriate epics. This will be a good testcase to ensure the switchover
worked fully.

-Ian

On Sun, Feb 23, 2020 at 4:36 PM Eeli Kaikkonen <eeli.kaikkonen@xxxxxxxxx>
wrote:

>
>
> On Sat, Feb 22, 2020 at 4:48 PM Brian Piccioni <
> brian@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
>> Hello
>>
>> Now that Geographic Reannotation is a WIP I was thinking it might make
>> sense to update eeSchema's Annotate dialog.
>>
>
> I created an epic for annotation related issues. You should probably file
> each proposition as a report if there's no report already.
>
> https://gitlab.com/groups/kicad/code/-/epics/19
>
>
>> Incorporate undo
>>
>
> There's an existing issue for "Back annotation changes unable to be
> undone in schematic", but there are more problems with Annotation.
>
> With one simple component open the annotation dialog, annotate and close.
> The component is annotated, but:
>
> 1) "Save" is not activated in the toolbar. It's activated in the File
> menu. But when I click on the canvas, the button is activated.
>
> 2) There's no undo. If I annotate manually by editing the refdes, Undo
> works. IIRC Undo has worked previously.
>
> These must be reported separately, right? (I'm asking from the senior
> developers.)
>
> Eeli Kaikkonen
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>