← Back to team overview

kicad-developers team mailing list archive

Re: Annotation Epic/Geographic reannotation



Thanks for the reply. I was referring to https://gitlab.com/kicad/code/kicad/-/merge_requests/108, not the earlier one which I borked.

I understand people have lots of things to do but given my lack of expertise I am never sure if its something I did or just part of the process so I always assume radio silence means I screwed something up.

I think !108 is pretty up to date with master. I will have to push a new version with consistent handling of references with eeSchema.


On 2020-03-01 7:31 p.m., Jon Evans wrote:
Hi Brian,

I haven't looked at your MR yet since it seemed like a lot of other people were already engaged and I think "too many cooks in the kitchen" can be a detriment to code review. I just opened it up today and noticed that it needs to be rebased on master (can't be done automatically, which probably means some code it is based on has diverged)

@Ian McInerney <mailto:Ian.S.McInerney@xxxxxxxx> since you already were reviewing, any comments on the latest?


On Sun, Mar 1, 2020 at 12:06 PM Brian Piccioni <brian@xxxxxxxxxxxxxxxxxxxxx <mailto:brian@xxxxxxxxxxxxxxxxxxxxx>> wrote:


    I haven't had any feedback/comments regarding my merge request or
    Annotation suggestion for quite a few days now so I don't know
    my comments/pushes are being broadcast or people are simply busy
    on other things.

    So, sorry for the spam.

    I just added this to the Annotations epic
    (https://gitlab.com/groups/kicad/code/-/epics/19) as I have been
    on annotation. I would appreciate any feedback on the issues

    1) No undo for annotation dialog
         Problem: eeSchema undo seems to be page confined.
         Fixing this would probably be a good idea but a lot of work and
    likely beyond my abilities
         at a this time. I can make a special "undo" stack for
    annotation as
    a stop gap.

    2) Annotate while adding is a WIP see

    See https://bugs.launchpad.net/kicad/+bug/1660134 for items 4 - 6.
    4) Annotate selection

         I should be able to manage this

    5) Anotate without a number
    6) Annotate number only.

        5 and 6 seem pretty straightforward to implement though there are
    filters on dialogs which will
        have to be fixed. There may be an issue with transfer between
    schematic and PCB
        (i.e. Update PCB to/from schematic) as well as geographic
    from the PCB as error
        checking is done on all of these. I am working on a unified
    reference "splitter" for eeSchema and
        PCBNew to ensure consistency.

        My concern is that annotation seems pretty well woven into
    DRC, library editor, etc., and
        something will break if we do this. For example, having a
    with RK causes DRC to ask for
        annotation as does updating PCB from Schematic. If things
    break they
    can be fixed, but what if the
        breakage is only apparent on edge conditions? How can we test?

    8) Subsheets don't match multi-unit element annotations. (lp:#1788976)
        I do not understand this

    9) Implement more (and custom?) annotation schemes
        I have already coded prefixs to allow for IEE 200, etc.. One can
    then annotate sheet by sheet
        to give a prefix to each sheet. Alternatively we could add a
    specific symbol/flag/notation
        which defines a prefix per sheet. I suspect that reannotating
    sheet with a sheet prefix
        would meet most use cases.

    10) Clear annotation does not work under MSW
         I cannot replicate this. The results I get are different from
    video. It works fine for me.

    Mailing list: https://launchpad.net/~kicad-developers
    Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
    Unsubscribe : https://launchpad.net/~kicad-developers
    More help   : https://help.launchpad.net/ListHelp

Follow ups