← Back to team overview

kicad-developers team mailing list archive

Re: Error creating merge request for 1st diff

 

Thanks Andrew and Jon - that helped me figure it out. I think I just
successfully submitted my first merge request (# 282).
-Josh


On Mon, Jul 13, 2020 at 1:09 PM Jon Evans <jon@xxxxxxxxxxxxx> wrote:

> Good point, Andrew.
>
> I normally have my fork as "origin" (which will be the default when
> doing push/pull operations).
>
> I set the main KiCad repository as a remote called "upstream" (this
> name is just my personal choice, it can be anything)
>
> That way by default I am just interacting with my fork, but I can
> specify the upstream remote if I am rebasing my changes on top of the
> latest in the main repository.
>
> Some more detail here on how to add, view and rename remotes:
>
> https://git-scm.com/book/en/v2/Git-Basics-Working-with-Remotes
>
> -Jon
>
> On Mon, Jul 13, 2020 at 12:58 PM Andrew Lutsenko <anlutsenko@xxxxxxxxx>
> wrote:
> >
> > Hi,
> >
> > You are probably trying to push to kicad repo instead of your fork.
> > Instead of doing "git push" you should do "git push <name of remote
> corresponding to your fork>" unless your fork remote is "origin".
> > Once you have pushed to your fork git client will give you a direct link
> to create a merge request from that branch.
> >
> > Best,
> > Andrew
> >
> > On Mon, Jul 13, 2020 at 9:25 AM Joshua Redstone <redstone@xxxxxxxxx>
> wrote:
> >>
> >> Hi,
> >> I've prepared a diff for the raytracing engine in 3d-viewer.  It more
> conservatively clips silkscreen around vias to the edge of the outer
> annular ring rather than edge of the copper plating.
> >> I wanted to get some feedback on it, but when I tried creating a merge
> request by doing a git-push, I got the "You are not allowed to push code to
> this project." error.
> >>
> >> Is there another way I should proceed to get feedback on the diff?
> >> One question on the diff I had was I wasn't sure where / if / how to
> hook up the flag enabling the change.
> >>
> >> Thanks,
> >> Josh
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
>

References