← Back to team overview

kicad-developers team mailing list archive

Re: Questions to the QA code


Hi Sylwester-

I haven't used HippoMocks but in general, adding QA tests is always welcome
as long as they run as expected under the Fedora docker we use for online
QA with GitLab.

The downside of HippoMocks from what I can gather is that the project
appears abandoned.  If I'm incorrect here, can you link to the current


On Fri, Jan 15, 2021 at 2:49 PM Sylwester Kocjan <s.kocjan@xxxxx> wrote:

> Hello,
> I have two questions regarding QA code for KiCad and I'd like to ask for
> your comments about them:
> 1. I reviewed contents of qa directory in KiCad repo and I saw some issues
> that can be fixed.
>    Could you please take a look at the summary and let me know if they are
> valid:
> https://docs.google.com/spreadsheets/d/14QAy9rRIHqRr4YuXfQO2GicURAG1BgJmwKe7B1H6xXI/edit#gid=326687467
> 2. What do you think about adding mocking library to the KiCad code? I
> found that PGM object is mocked few times
>    https://gitlab.com/kicad/code/kicad/-/issues/4446#note_342766728
>    A libary for creating mocks would simplify creting the tests. In this
> MR and commit:
>    https://gitlab.com/kicad/code/kicad/-/merge_requests/542
> https://gitlab.com/kicad/code/kicad/-/merge_requests/542/diffs?commit_id=b7b401d7128057831c049a723ffc895453d65a0e
>    there is added HippoMocks, a single-header mocking tool and it does
> it's job.
>    If that's ok, it could help to get rid of these duplicated mocks (maybe
> even hand-written mocks at all).
> Best regards,
> Sylwester
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

[image: KiCad Services Corporation Logo]
Seth Hillbrand
*Lead Developer*
Long Beach, CA
www.kipro-pcb.com    info@xxxxxxxxxxxxx

Follow ups