kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Hi Sylwester,

I don't know that we need to support SI units in spice strings but I 
suppose it wouldn't hurt.  That would have to wait until V7 as it is a 
new feature.  The test cases look correct so I don't see any issues here.

- Wayne

On 5/18/21 2:06 PM, Sylwester Kocjan wrote:
> Hello!
>
> I've noticed a minor bug in SPICE_VALUE class. Could you please let me 
> know if we should parse SI units in SPICE strings or ignore them, so I 
> can fix it? I think ngspice accepts units like, V, I, Ohm, but this may 
> be an overkill. The easiest solution is to ignore everything after 
> number and prefix.
>
> See below the testcases I made on AC tab of Simulation Settings dialog:
>
> Input:      Actual behavior:        Expected behavior:
> 10m         Value parsed correctly  Value parsed correctly
> 10mHz       Value parsed correctly  Value parsed correctly
> 10mHzz      Value parsed correctly  Exception thrown
> 10Hz        Exception thrown        Value parsed correctly
> 10Hzz       Exception thrown        Exception thrown
>
> Best regards,
> Sylwester
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp