launchpad-dev team mailing list archive

[Tim Penhey <tim@xxxxxxxxxx>]

> Uploaded new version to:
> http://people.canonical.com/~beuno/branch-index2.png (that's all I could
> get done today)

I'll try to keep the points short and concise.

 1) We want to be careful about edit icons next to the branch name, owner or 
target (which isn't shown at all).  Any change to these will change the 
location of the branch.  We shouldn't really make it too easy to change these.

 2) The description on the branch looks like it was intended for a merge 
proposal.  I was thinking of having a description like the new bug 
description, where if there is one we have the javascript multiline edit.  
However the main change here is bugs *must* have a description, but most 
branches won't.  However users want one.
  - If there is no description, don't show anything
  - Add a "Change branch details" below "Delete this branch" (or above, I 
don't care) which allows the setting of a description - and ownership, name 
and probably target.
  - If the description is there, put it between the owner and the propose for 
merging.

 3) you have the following text:
   Propose for merging in to lp:launchpad (Default review is The Launchpad 
hackers)
     - The edit icon next to the launchpad hackers is supposed to edit what?
     - Do we show this link for the development focus branch?  What about 
other branches linked to series?  What about import branches (a current 
annoyance of mine)?

 4) I do like the use of the new merge proposal icon.  We still have the issue 
that "Propose for merging into lp:launchpad" doesn't say anything about code 
reviews.  How can we fix that?  A help link?  In-page help maybe?  If we did, 
what would we link it off?

I have been thinking a lot about this.  I think for feature branches are are 
interested in three things:
  * What bugs does this branch fix or blueprints implemented
  * What is the status of the code review
  * What are the changes in this branch

It would be great if we could answer these three questions just by looking at 
a branch page (for a feature branch).  Perhaps by adding the following:
 * If there is a review in progress, show the review summary
 * If we have a diff, show that too, or at least a link to it

 5) For import branches we are more interested in the status of the import, as 
currently shown for import branches.

 6) For series linked branches, we want the following:
  * No links for bugs and blueprints (controversial)
  * Show the review team, and an edit icon if the user can update it
  * A link showing the number of current merge proposals that links to a 
simple listing.
  * A big sparkline of commits (or whatever we want the sparkline to show)
    - poolie and lifeless have some ideas here
  * Eventually I'd like to see a rendering of a README file (maybe)
  * A trunk branch is more likely to have a description


Looking at these I see that some are neither short nor concise.  Sorry.

Tim