launchpad-dev team mailing list archive

[Tim Penhey <tim@xxxxxxxxxx>]

Thanks Elliot for the praise.

I'm wanting to tweak the workflows around code reviews slightly anyway.

Here is what I'm thinking right now.

When a new branch is created on launchpad, we can look at the target of the 
branch (project or package) to see if it looks like the branch is a feature 
branch (most will be).  If we think it is, then we create a "work in progress" 
merge proposal, but don't send any emails at this stage.  This allows us to 
create moving diffs as the users push changes to launchpad.

If we have chosen the wrong branch, then we allow the user to update the 
target, like changing lp:launchpad for lp:launchpad/devel.  This will cause 
the diff to be regenerated.

When the user wants the review, they just say "now this needs a review".  This 
will change the state from "work in progress" to "needs review".  This will 
cause the review email to be sent, and start the review process.  We could 
even stop traversal to merge proposals that are in "work in progress" to stop 
comments being added prematurely.

Ideally, I'd like to show this diff on the branch page itself, so the casual 
observer of branches could see at a glance what the branch introduces.

This would require us to constrain the merge proposal creation so there could 
be only one that is active at a time.

Tim