launchpad-dev team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> 2009/8/21 Aaron Bentley <aaron@xxxxxxxxxxxxx>:
>> I think "propose for merging" would fit better in the menu.  "Delete
>> this branch" looks lonely :-)
> 
> "Propose for merge" should be an action that people do all the time,
> so its position and prominence should reflect that.

AIUI, the rules are that if the action affects something unseen, i.e.
the context object, it should go in a menu.

>> I don't know why you're forcing the merge to be proposed into
>> lp:launchpad.  How would I propose a merge into db-devel, for example?
>>
>> I think by "Default reviewer" you mean the review team of
>> ~beuno/launchpad/project-group-custom-icons.  But the review team
>> lp:launchpad will be used (not the review team of the source branch) if
>> you propose a merge of project-group-custom-icons into lp:launchpad, so
>> the association of this item with "propose for merging in to
>> lp:launchpad" is very misleading.  I recommend putting "review team"
>> next to "owner".
> 
> It's not very clear to me what 'review team' means

It is the group of people who are trusted to perform reviews.  When a
review is proposed, they are requested to review by default.  Reviews
from people who are not in this team are flagged as "(community)" in the
UI, to distinguish them from those fully trusted.

> or why you'd want
> to know about it now.

I guess you could hide it in a "branch details" page if you wanted.

>  I thought it would mean 'people who get
> notified' but apparently not.

A side effect of being requested to review is that you'll get notified,
so members of the review team will get notifications when the review
team is requested to review.  (Which is the default.)  To cause the
review team to always get notifications, subscribe them to the branch as
you would any other team.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqOJh4ACgkQ0F+nu1YWqI0h5ACfZ7qw972lsrf5UUtFI0/e5eGn
EV8An29oI2Dk32etTgJ4midfub0HoYQ/
=3g/g
-----END PGP SIGNATURE-----