← Back to team overview

launchpad-dev team mailing list archive

Re: Putting on-call reviewer in channel topic?

 

Aaron Bentley <aaron@xxxxxxxxxxxxx> writes:
> Karl Fogel wrote:
>> Tell me if I'm reheating an old discussion here:
>> 
>> Today I looked for an on-call reviewer (OCR), and suddenly realized how
>> much nicer it would be if the OCR were listed in the channel topic in
>> #launchpad-dev.
>
> We already list it in the channel topic of #launchpad-reviews.

Hmm.

Do we need a separate channel for that?  Do reviews tend to be noisy
enough that having them in #launchpad-dev would be disruptive to other
conversations there?

I think it would be much, much better not to divide our development
activity up like this.  It's better when people can see what's going on
right where they are, and learn what reviewers are looking for just by
hanging out in the usual place.  (If a review is going to be especially
noisy, then it could go to a separate channel on an as-needed basis, but
most probably won't need that.)

Just yesterday I was in #launchpad (not even #launchpad-dev!) discussing
a coding/testing issue, and it (apparently) caused Michael Bienia to
revive his interest in fixing bug #325367, which he then did.  These
sorts of spontaneous interactions are important, and they happen less
often if we split different activities into different channels.

Proposal:

   1) Eliminate #launchpad-reviews as a permanent channel.
   2) Just do reviews in #launchpad-dev.
   3) When a review gets noisy, create a temporary channel for it (maybe
      #launchpad-reviews can be used for that, but I don't think it
      matters much), and make sure others in #launchpad-dev know when a
      discussion is moving over there.
   4) OCR updates channel topic in #launchpad-dev now, instead of
      #launchpad-reviews.

Thoughts?

-Karl



Follow ups

References