launchpad-dev team mailing list archive

[Abel Deuring <abel.deuring@xxxxxxxxxxxxx>]

On 29.07.2010 15:25, Aaron Bentley wrote:
> On 07/29/2010 07:52 AM, Abel Deuring wrote:
>> Hi Stuart,
> 
>> I am currently working on
>> https://bugs.edge.launchpad.net/malone/+bug/39674 (Attachments of
>> private bugreports are public). This involves of course to set the
>> attribute LFA.restricted to True for private bugs.
> 
>> My first idea was to simply set the restricted flag of all LFAs of
>> BugAttachments of a bug in the method Bug.setPrivate().
> 
>> But a comment from Robert in
>> https://code.edge.launchpad.net/~adeuring/launchpad/bug-39674-lfa-editable/+merge/29314
>> let me think again if we should enforce the consistency of
>> LFA.restricted and Bug.private on the database level.
> 
> Another option is to just make all bug attachments restricted, and let
> the bug provide access to the attachments as appropriate.  This is the
> approach we used with merge proposal diffs.

Right. But I am not sure if we really want to serve files with a size
of, let's say, 5MB via StreamOrRedirectLibraryFileAliasView.__call__()
if the content is public.

Abel