launchpad-dev team mailing list archive

[Brad Crittenden <bac@xxxxxxxxxxxxx>]

On 08/10/2010 02:41 AM, Stuart Bishop wrote:
> On Tue, Aug 10, 2010 at 5:03 AM, Robert Collins
> <robert.collins@xxxxxxxxxxxxx> wrote:

>> Hi Brad; since the epic - and Stuarts update last week about DB
>> process - please have either Stuart or I review DB patches - we want
>> to stop distracting Jono with code :)
>>
>> https://dev.launchpad.net/PolicyAndProcess/DatabaseSchemaChangesProcess

Hi Robert,

Sorry I missed that change but will keep it in mind for the future.

>>
>> If I had seen that patch I would have raised a few questions with you:
>>  - is it possible to use NULL rather than an explicit value (will make
>> the patch apply _much_ faster)
> 
> It applies faster, but will be less correct and make queries nuts as
> you have to use 'IS' for checking for NULL and = for checking for
> integer values. Using NULL as the default would require a data
> migration job (populating the new column) and a second patch the
> following cycle (adding in the NOT NULL constraint).
> 
> (Not that it matters - there are only 25k rows to update so it should be quick).

Based on Stuart's explanation I think it should stay as is.

--bac