launchpad-dev team mailing list archive

[Gavin Panella <gavin.panella@xxxxxxxxxxxxx>]

On 21 October 2010 12:00, Julian Edwards <julian.edwards@xxxxxxxxxxxxx> wrote:
> On Thursday 21 October 2010 11:32:29 Graham Binns wrote:
>> On 21 October 2010 11:20, Julian Edwards <julian.edwards@xxxxxxxxxxxxx>
> wrote:
>> > What I find extremely irritating is nitpicking over minor formatting and
>> > grammatical issues.  The first thing that pops into my head when someone
>> > does this, with no other comments about my code, is "you've not really
>> > looked at what this patch is doing, have you?"
>>
>> I hope that the second thing you think is "that's unfair of me, bad
>> Julian."
>
> Not really.  It does largely depend on the style of review but I've had
> reviews of fairly complicated changes before where I was expecting questions
> about how something worked (this is Soyuz, right?) and had nothing except a
> request to add a full stop at the end of a comment (for example).
>
> At the very least, if the reviewer did understand the branch, I'd expect a
> comment to that effect confirming the action taken in the changes.
>
> This could also be a symptom of reviewer fatigue though.

Yes. I have little understanding and/or experience with Translations
and Soyuz especially. Acquiring experience and knowledge of the those
systems from reviews is slow at best. Sometimes the best I can do is
check style and grammer, suggest simple refactorings or use of
existing features or libraries.

I'm in a lucky position that everyone uses Bugs, so all reviewers can
grasp anything I propose (unless it's been at the mushrooms, natch).