launchpad-dev team mailing list archive

[Julian Edwards <julian.edwards@xxxxxxxxxxxxx>]

On Friday 22 October 2010 12:29:50 Deryck Hodge wrote:
> On Fri, Oct 22, 2010 at 6:19 AM, Julian Edwards
> 
> <julian.edwards@xxxxxxxxxxxxx> wrote:
> > On Friday 22 October 2010 04:02:41 Robert Collins wrote:
> >> I do like the idea of catching problems early, but let's do that
> >> explicitly: I will review *all* unreviewed landings (other than ones I
> >> do) in the two weeks, and if I land anything unreviewied, someone else
> >> - say jml - can review those.
> >>  - javascript reviews
> >>   - sure, let's leave them out of scope
> > 
> > Can anyone remember why we abandoned [r=trivial] ?
> > 
> > >From what I remember of it, we seemed to use it for more than just
> > >"trivial"
> > 
> > branches; i.e. mechanical changes etc., and I reckon what we were doing
> > back then is not too dissimilar to Rob's proposal.
> 
> Actually, I don't think this is what Rob is proposing.  I think he is
> saying qualified contributors can take reviews at their discretion.
> Period.

Sure, I understand that.

What I am saying is that it will end up looking very much like the old way of 
doing things if people take reviews when they know they ought to.  Officially, 
this proposed way is slightly more lenient on that requirement though.

Cheers.