launchpad-dev team mailing list archive

[Aaron Bentley <aaron@xxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10-12-15 10:54 PM, Ian Booth wrote:
>>
>> The best way to check whether a plugin is properly installed is to run
>> "bzr plugins", e.g. "bzr plugins|grep lpreview_body".  There is no "bzr
>> lpreview-body" command-- instead, it provides functionality that hooks
>> into the existing lp-propose command.
>>
> 
> Yeah, I did that initially and there's no lpreview_body plugin.

Okay, maybe we can dig into that on Monday.  That's just odd.

> But
> there's also no lppropose plugin either.

Right.  The lp-propose command is provided by the launchpad plugin that
ships with bzr.

> There is a launchpad 2.2.1
> plugin and I had thought everything needed was part of that.

I'm not sure what you mean by "everything needed".  The launchpad plugin
includes everything needed to run lp-propose normally, but not
lpreview_body.

>> Your problem might be caused by an inability to lint.  Does bin/lint.sh
>> run successfully?  (Not "make lint"-- that will build bin/lint.sh
>> first.)  It appears the packaged version is somewhat behind the times,
>> and still susceptible to this bug, which was fixed last February.
>>
> 
> Yes, I use it all the time when creating mp's via the web ui.

I don't know what your workflow is, but my workflow means that every
time I start a new feature branch I have a new working directory.  Since
bin/lint.sh is created by buildout, I don't have lint.sh until I run make.

If you are always reusing your working diretory, this would not apply to
you.  But if you use fresh working directories, then it's possible for
bin/lint.sh to be missing.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk0JlWQACgkQ0F+nu1YWqI0TbQCeI9W7DjD1BE0gOQivhLUk3FdO
/xcAn0YAc/8heqHv120HHiVUllFG/S4f
=mUIU
-----END PGP SIGNATURE-----