← Back to team overview

launchpad-dev team mailing list archive

Re: PythonStyleGuide reduced

 

On 25 January 2011 09:57, Henning Eggers <henning.eggers@xxxxxxxxxxxxx> wrote:
> Am 24.01.2011 08:26, schrieb Aaron Bentley:
>> I think we should keep "Importing a module should not have side
>> effects".  One of the libraries used by launchpadlib for storing
>> passwords does this, as does lp.codehosting, so we can't assume people
>> will avoid it.
>
> We removed stuff that we felt is general software engineering knowledge that
> everyone working here should know.

+1, in fact I think you should also omit things that are general
Python knowledge.  (Things that are "general Zope knowledge" etc
perhaps should be included or at least pointed to, since not everybody
will know them.)

> Side effects are always bad, that is not
> Launchpad-specific. Are we expecting too much possibly?

-- 
Martin



Follow ups

References