launchpad-dev team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

On Fri, Feb 11, 2011 at 4:42 PM, John Arbash Meinel
<john@xxxxxxxxxxxxxxxxx> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>>> I'm also stuck with stuff that was originally proposed against the old
>>> lp:loggerhead, which is no longer the "future" branch, and I don't have
>>> any idea what branch I'm actually supposed to be proposing against or
>>> merging into. (nor what the correct method for doing so is.)
>>
>> If you are finessing the future stuff that was put off into the
>> experimental branch, propose a merge to it and get it reviewed by a
>> loggerhead-team member (which includes all of ~launchpad - so lots of
>> folk that can help). To land in that branch, just land directly. I'd
>> like to suggest that only direct fixes to make it ok to land that
>> branch should be done there (that and merges from trunk to keep it
>> fresh).
>>
>
> Sure. There are some YUI changes, etc, but I'm hoping most of those were
> already in PQM.
>
>
>> If you are doing stuff for trunk, for what should be 1.19 - I think a
>> good first step is a new release with all the fixes from LP, a release
>> that LP can use *as is*, no patches, no tweaks, just ready-to-go. This
>> will mean making the search widget optional in the tal, for instance.
>>
>
> Do you have any other ideas of what is required? From the other discussion:
>
> 1) There is the UI/color scheme issue.

I'd like to have someone with UI gumption eyeball the two themes and
decide if we can just pick one and use it; that would be easiest
overall. If not, we'll need to add to the launchpad glue a new theme.

> 2) Search, and integration with bzr-search, but as you mention, it may
> have a scaling problem with Launchpad sized stuff. I'm not entirely
> clear how to make that sort of thing optional in tal.

<div tal:condition="something goes here">...</div> - the something is
a tal expression; if it ends up in a callable, the callable is called,
Once thats resolved, the resulting expressions __nonzero__ is
evaluated.

>> lp:loggerhead/experimental, and via the standard launchpad merge
>> system. Loggerheads branchs show up in
>> https://code.launchpad.net/launchpad-project/+activereviews, and you
>> should get reviews from LP code reviewers. If you don't, or you want
>> one done immediately, pop into #launchpad-dev and ask the on call
>> reviewer; if there isn't one, just ask around - I'm sure someone will
>> be delighted to review your changes.
>
> It would be nice if it was "lp:loggerhead/experimental" it is actually
> "lp:~loggerhead-team/loggerhead/experimental" which is a bit to type.
> But now I have it, it isn't critical for me anymore.

You should be able to create a series; I didn't initially because we
don't really want this hanging around all that long, but if you want
one for convenience I certainly won't object.

> I did end up getting a review from Gavin. Prior to that, it was a whole
> lot of nothing for a couple weeks. When I brought it up, Martin started
> noticing as well. When I went to #launchpad-dev the on-call reviewer was
> "-" and he just wouldn't respond to any of my private messages. :)

The lp review team has discussed, but I don't know that they have
actioned, transitioning to looking at
https://code.launchpad.net/launchpad-project/+activereviews as the
work queue for the on call reviewer.
https://dev.launchpad.net/ReviewerSchedule has the reviewer schedule,
and note that folk - particularly team leads - that are reviewers and
not in a scheduled spot can always be pinged for a review. Its kind of
their quid pro quo for not being in the roster :)

Ok, I made that last bit up. But really, they will do reviews if you ask.

-Rob