launchpad-dev team mailing list archive

[Robert Collins <robertc@xxxxxxxxxxxxxxxxx>]

On Wed, Feb 16, 2011 at 3:36 AM, Benji York <benji.york@xxxxxxxxxxxxx> wrote:
> Thanks for writing this up I made a couple of typo fixes and
> clarifications:
> https://dev.launchpad.net/FeatureFlags?action=diff&rev2=10&rev1=8
>
> I also have a couple of questions/observations:
>
> The use of the word "scope" in the "Flag naming" section (i.e.,
> "scope.feature.effect") confused me for a second because "scope" there
> doesn't mean the same thing as "scope" in the rest of the document.

Hmm. perhaps s/scope/conceptual area/ there might help?

> The bit about priorities being totally ordered isn't enforced in the
> code.  Is that a bug?

Its enforced in the data model in the DB, attempting to use the same
(flag, priority) twice will result in a data integrity error.

>
> What should we do with the large docstring at the top of
> lib/lp/services/features/__init__.py?  It covers much of the same
> material.

Publish it on the wiki automatically!

-Rob