launchpad-dev team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

>>
> Fantastic work guys, this is really great to see! Is there anything left
> to do to consider this work complete?
>>

There's always more to do :-)

There's only one absolutely necessary item to finalise:
Bug 807426 Long poll yui tests not run automatically

Raphael (I think) has this on his todo list.

I'd personally like to see the 3 (or 4?) different expander
implementations replaced by the nice work danilo has done in producing a
new expander widget. We wanted to get the Javascript files all nice and
stable first which has now been done. But strictly speaking this todo is
not really part of the core work I described in my email. Although since
we are on a roll, it would be great to get rid of this technical debt
sooner rather than later.

Another item to consider for the future is the location of our
Javascript files. We currently do:

lib/lp/<silo>/javascript/... (where silo = app, code, bugs, etc)

The longpoll implementation has done:

lib/lp/app/longpoll/javascript/...

ie lib/lp/<silo>/<module>/javascript

This latter approach allows us to better keep all code artefacts for a
given module together in the source tree rather than (in the case of
Javascript) just dumping all bugs code under bugs/javascript etc.

Truly generic, reusable components/libraries would live in
app/javascript and the integration of the lazr-js source has introduced
a nice directory structure under app: app/javascript/picker/... etc.

So stuff we have sitting in the big buckets directly under
app/javascript, bugs/javascipt, etc could conceivably over time be moved
to a better location. eg bugs/subscribers/javascript etc

Thoughts?