launchpad-dev team mailing list archive

[Ian Booth <ian.booth@xxxxxxxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> 
>> Also we have some apprehension that something might be missing from
>> our implementation of RemoveSubscriptionsJobSource. Can someone
>> take a look at the pieces and tell us if something is missing that
>> is needed to run in production.
> 
> I can't find anything by that name in r15284
> 


Hi Aaron

I haven't landed any of my branches which introduce the new Celery jobs
yet since I am waiting for Celery to be ready. I think my basic
implementation is ok based on the CeleryJobs wiki page and have unit
tests using the CeleryLayer which seem to confirm this. But I am unsure
what, if anything, I need to do with respect to error handling, retry on
failure etc. Perhaps that is all done as part of the Celery framework?
But then again, how would the framework know the difference between a
fatal error that means the job must be aborted vs a transient error
where the job can be retried. Are there any expected classes of
exceptions one should raise in the run method which the framework relies
on to determine how it should handle failure? Do I need to do anything
to account for the job runner aborting half way through a job - will the
job be automatically rerun?

Thanks.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iJwEAQECAAYFAk+8KqoACgkQCJ79BCOJFcY/qwP+M2xK6dq81n+UIyZCuuVPwUxv
l4aeO/359XAtKQ7oT8b2e9Q5MKv6veZrwB2aAAutWHj6zSBmkaUg1Yfcq6LCcptV
18cyxApzlNYrxi8bX8hnkqUoirigs+pUVCMSIT2LrkK510UlKJfw+Z88AjoHY+x3
+2PzJYWPALLpVQKJrSE=
=j3Hp
-----END PGP SIGNATURE-----