← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~leonardr/launchpad/launchpadlib-integration into lp:launchpad

 

Sorry, this is the wrong branch for that MP. Here's the real MP.

This branch makes some minor changes to launchpadlib that I made while integrating my branch https://code.launchpad.net/~leonardr/launchpadlib/launchpad-integration into Launchpad.

* Require new versions of launchpadlib and lazr.restfulclient
* Require the 'keyring' module, a new dependency of launchpadlib
* Many tests invoke the Launchpad constructor, which now takes two new arguments (a token authorization engine and a credential store). These tests don't need either, which is why they're invoking the constructor instead of using login_with(). I changed the tests to pass in None for those two arguments.

-- 
https://code.launchpad.net/~leonardr/launchpad/launchpadlib-integration/+merge/45174
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~leonardr/launchpad/launchpadlib-integration into lp:launchpad.



References