launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

William Grant has proposed merging lp:~wgrant/launchpad/makeBug-testfix into lp:launchpad.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/makeBug-testfix/+merge/45200

LaunchpadObjectFactory.makeBug was changed to create a series tasks if a series is specified. Except that it actually creates one whenever a milestone *isn't* specified, which doesn't work well when no series is specified.
-- 
https://code.launchpad.net/~wgrant/launchpad/makeBug-testfix/+merge/45200
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/makeBug-testfix into lp:launchpad.

=== modified file 'lib/lp/testing/factory.py'
--- lib/lp/testing/factory.py	2011-01-04 23:32:39 +0000
+++ lib/lp/testing/factory.py	2011-01-05 03:01:39 +0000
@@ -1443,7 +1443,7 @@
                 BugTaskStatus.FIXRELEASED, owner, when=date_closed)
         if milestone is not None:
             bugtask.transitionToMilestone(milestone, milestone.target.owner)
-        else:
+        if series is not None:
             task = bug.addTask(owner, series)
             task.transitionToStatus(status, owner)