launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

On Fri, Apr 27, 2012 at 02:05:21PM -0000, Brad Crittenden wrote:
> In the test you restored, test_verifyFormat_xz_good_predep, is it
> still necessary to have the 'Pre-Depends' in the control in order for
> the upload to be accepted?  Perhaps you can keep the test, though
> rename it, and remove the dependencies that are made obsolete by your
> branch.

It isn't necessary to have the Pre-Depends any more, no.  I've pushed a
change that removes it.  How's that?

> Once ready I'll be happy to land it for you.
> 
> Normally I'd mark this as 'Approved' but this time I'm setting it to
> 'Needs fixing' as a reminder that I need to revisit it when you've
> made the change and then land it.  

Thanks.  I have PQM access these days, though, so all I need is for a
member of ~launchpad to set the MP status to Approved when you're happy
and then I can land it myself.

-- 
https://code.launchpad.net/~cjwatson/launchpad/remove-data-tar-xz-version-requirement/+merge/103859
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.