← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~allenap/maas/fast-path-installer-tag into lp:maas

 

> Thinking about a), I'm starting to think that adding a field on the
> node might have been a bit cleaner… I know we talked about this
> yesterday and I don't want to slow you down but what are the reasons
> why you want this as a tag?

The reason is so that (a) the tag can be defined node by node, or by a
tag expression (e.g. "use the traditional installer with a particular
wonky RAID controller"), and (b) so nodes can be selected at acquire
time, to include or exclude those nodes that will use the non-fast
installer.

If neither of these is desirable, or just not worth the effort for the
benefit, then I agree that putting a field on Node is easier and
cleaner.

-- 
https://code.launchpad.net/~allenap/maas/fast-path-installer-tag/+merge/148155
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~allenap/maas/fast-path-installer-tag into lp:maas.


References