← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] ~lgp171188/launchpad:update-favicon-sizes into launchpad:master

 

Guruprasad has proposed merging ~lgp171188/launchpad:update-favicon-sizes into launchpad:master.

Commit message:
Add favicons in various sizes and forms required by browsers

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/423966
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:update-favicon-sizes into launchpad:master.
diff --git a/lib/canonical/launchpad/images/android-chrome-192x192.png b/lib/canonical/launchpad/images/android-chrome-192x192.png
new file mode 100644
index 0000000..c9a9339
Binary files /dev/null and b/lib/canonical/launchpad/images/android-chrome-192x192.png differ
diff --git a/lib/canonical/launchpad/images/android-chrome-512x512.png b/lib/canonical/launchpad/images/android-chrome-512x512.png
new file mode 100644
index 0000000..430d370
Binary files /dev/null and b/lib/canonical/launchpad/images/android-chrome-512x512.png differ
diff --git a/lib/canonical/launchpad/images/apple-touch-icon.png b/lib/canonical/launchpad/images/apple-touch-icon.png
new file mode 100644
index 0000000..f5737bf
Binary files /dev/null and b/lib/canonical/launchpad/images/apple-touch-icon.png differ
diff --git a/lib/canonical/launchpad/images/browserconfig.xml b/lib/canonical/launchpad/images/browserconfig.xml
new file mode 100644
index 0000000..0c58bb3
--- /dev/null
+++ b/lib/canonical/launchpad/images/browserconfig.xml
@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="utf-8"?>
+<browserconfig>
+    <msapplication>
+        <tile>
+            <square150x150logo src="/@@/mstile-150x150.png?v=2022"/>
+            <TileColor>#da532c</TileColor>
+        </tile>
+    </msapplication>
+</browserconfig>
diff --git a/lib/canonical/launchpad/images/favicon-16x16.png b/lib/canonical/launchpad/images/favicon-16x16.png
new file mode 100644
index 0000000..d520968
Binary files /dev/null and b/lib/canonical/launchpad/images/favicon-16x16.png differ
diff --git a/lib/canonical/launchpad/images/favicon-32x32.png b/lib/canonical/launchpad/images/favicon-32x32.png
new file mode 100644
index 0000000..ff05d03
Binary files /dev/null and b/lib/canonical/launchpad/images/favicon-32x32.png differ
diff --git a/lib/canonical/launchpad/images/favicon.ico b/lib/canonical/launchpad/images/favicon.ico
new file mode 100644
index 0000000..8c4c834
Binary files /dev/null and b/lib/canonical/launchpad/images/favicon.ico differ
diff --git a/lib/canonical/launchpad/images/mstile-144x144.png b/lib/canonical/launchpad/images/mstile-144x144.png
new file mode 100644
index 0000000..a3e00c8
Binary files /dev/null and b/lib/canonical/launchpad/images/mstile-144x144.png differ
diff --git a/lib/canonical/launchpad/images/mstile-150x150.png b/lib/canonical/launchpad/images/mstile-150x150.png
new file mode 100644
index 0000000..fe8ae9a
Binary files /dev/null and b/lib/canonical/launchpad/images/mstile-150x150.png differ
diff --git a/lib/canonical/launchpad/images/mstile-310x150.png b/lib/canonical/launchpad/images/mstile-310x150.png
new file mode 100644
index 0000000..d0d1e33
Binary files /dev/null and b/lib/canonical/launchpad/images/mstile-310x150.png differ
diff --git a/lib/canonical/launchpad/images/mstile-310x310.png b/lib/canonical/launchpad/images/mstile-310x310.png
new file mode 100644
index 0000000..1e71545
Binary files /dev/null and b/lib/canonical/launchpad/images/mstile-310x310.png differ
diff --git a/lib/canonical/launchpad/images/mstile-70x70.png b/lib/canonical/launchpad/images/mstile-70x70.png
new file mode 100644
index 0000000..b9b58ad
Binary files /dev/null and b/lib/canonical/launchpad/images/mstile-70x70.png differ
diff --git a/lib/canonical/launchpad/images/safari-pinned-tab.svg b/lib/canonical/launchpad/images/safari-pinned-tab.svg
new file mode 100644
index 0000000..32e429c
--- /dev/null
+++ b/lib/canonical/launchpad/images/safari-pinned-tab.svg
@@ -0,0 +1,31 @@
+<?xml version="1.0" standalone="no"?>
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 20010904//EN"
+ "http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd";>
+<svg version="1.0" xmlns="http://www.w3.org/2000/svg";
+ width="700.000000pt" height="700.000000pt" viewBox="0 0 700.000000 700.000000"
+ preserveAspectRatio="xMidYMid meet">
+<metadata>
+Created by potrace 1.14, written by Peter Selinger 2001-2017
+</metadata>
+<g transform="translate(0.000000,700.000000) scale(0.100000,-0.100000)"
+fill="#000000" stroke="none">
+<path d="M0 3500 l0 -3500 3500 0 3500 0 0 3500 0 3500 -3500 0 -3500 0 0
+-3500z m4290 2561 c124 -27 237 -54 253 -60 33 -13 34 -28 6 -164 -57 -283
+-187 -567 -370 -809 -85 -113 -294 -319 -409 -405 -284 -212 -619 -357 -980
+-424 -108 -20 -157 -23 -365 -24 -250 0 -322 8 -508 55 -182 47 -403 142 -548
+235 -91 58 -119 83 -119 107 0 21 276 438 290 438 5 0 71 -31 147 -69 323
+-161 567 -220 852 -208 212 10 402 59 609 157 443 211 728 576 863 1105 16 62
+41 116 53 115 1 0 102 -22 226 -49z m1342 -893 c19 -15 238 -431 238 -451 0
+-18 -23 -37 -85 -72 -27 -16 -90 -55 -140 -88 -471 -313 -705 -731 -722 -1292
+-4 -132 -2 -194 12 -280 50 -320 204 -607 477 -891 43 -45 78 -90 78 -100 0
+-18 -267 -348 -312 -386 -30 -26 -41 -23 -110 34 -349 291 -583 709 -674 1203
+-22 121 -30 460 -15 607 68 649 406 1226 915 1560 80 53 296 168 315 168 4 0
+14 -6 23 -12z m-1923 -1179 c206 -47 348 -258 310 -462 -24 -134 -106 -243
+-226 -300 -63 -30 -76 -32 -173 -32 -97 0 -110 2 -172 32 -166 78 -261 258
+-229 431 43 233 265 383 490 331z m-1639 -555 c593 -86 1173 -459 1513 -974
+214 -325 328 -677 344 -1060 6 -158 -8 -328 -29 -342 -19 -14 -495 8 -520 23
+-10 6 -15 58 -19 206 -11 348 -69 574 -209 819 -181 314 -520 587 -875 702
+-154 50 -261 66 -455 66 -180 0 -298 -13 -479 -55 -47 -11 -90 -18 -97 -15
+-15 6 -164 450 -164 488 0 33 21 46 140 82 270 81 559 101 850 60z"/>
+</g>
+</svg>
diff --git a/lib/canonical/launchpad/images/site.webmanifest b/lib/canonical/launchpad/images/site.webmanifest
new file mode 100644
index 0000000..6c28a17
--- /dev/null
+++ b/lib/canonical/launchpad/images/site.webmanifest
@@ -0,0 +1,19 @@
+{
+    "name": "",
+    "short_name": "",
+    "icons": [
+        {
+            "src": "/@@/android-chrome-192x192.png?v=2022",
+            "sizes": "192x192",
+            "type": "image/png"
+        },
+        {
+            "src": "/@@/android-chrome-512x512.png?v=2022",
+            "sizes": "512x512",
+            "type": "image/png"
+        }
+    ],
+    "theme_color": "#ffffff",
+    "background_color": "#ffffff",
+    "display": "standalone"
+}
diff --git a/lib/lp/app/templates/base-layout.pt b/lib/lp/app/templates/base-layout.pt
index 86b4ee9..4a0c73e 100644
--- a/lib/lp/app/templates/base-layout.pt
+++ b/lib/lp/app/templates/base-layout.pt
@@ -25,7 +25,15 @@
   <head>
     <meta charset="UTF-8" />
     <title tal:content="view/fmt:pagetitle">Page Title</title>
-    <link rel="shortcut icon" href="/@@/launchpad.png" />
+    <link rel="apple-touch-icon" sizes="180x180" href="/@@/apple-touch-icon.png?v=2022">
+    <link rel="icon" type="image/png" sizes="32x32" href="/@@/favicon-32x32.png?v=2022">
+    <link rel="icon" type="image/png" sizes="16x16" href="/@@/favicon-16x16.png?v=2022">
+    <link rel="manifest" href="/@@/site.webmanifest?v=2022">
+    <link rel="mask-icon" href="/@@/safari-pinned-tab.svg?v=2022" color="#e9531f">
+    <link rel="shortcut icon" href="/@@/favicon.ico?v=2022">
+    <meta name="msapplication-TileColor" content="#da532c">
+    <meta name="msapplication-config" content="/@@/browserconfig.xml?v=2022">
+    <meta name="theme-color" content="#ffffff">
     <link
       rel="canonical"
       tal:define="url view/recommended_canonical_url | nothing"
diff --git a/lib/lp/services/webapp/configure.zcml b/lib/lp/services/webapp/configure.zcml
index c894270..bb5ddc0 100644
--- a/lib/lp/services/webapp/configure.zcml
+++ b/lib/lp/services/webapp/configure.zcml
@@ -157,7 +157,7 @@
         />
 
     <!-- Default favicon -->
-    <browser:favicon for="*" file="../../../canonical/launchpad/images/launchpad.png" />
+    <browser:favicon for="*" file="../../../canonical/launchpad/images/favicon.ico" />
 
     <!-- LaunchBag Utility -->
     <utility

Follow ups