launchpad-reviewers team mailing list archive

[Andrey Fedoseev <mp+423966@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/canonical/launchpad/images/site.webmanifest b/lib/canonical/launchpad/images/site.webmanifest
> new file mode 100644
> index 0000000..6c28a17
> --- /dev/null
> +++ b/lib/canonical/launchpad/images/site.webmanifest
> @@ -0,0 +1,19 @@
> +{
> +    "name": "",

I think we need to specify the name here ("Launchpad"), as it seems to be the mandatory parameter in the Web app manifest specs https://developer.mozilla.org/en-US/docs/Web/Manifest

short_name is optional, though, so we can probably drop it.

Also, I'm not sure if the `images` folder is the right place for the manifest file because it isn't specifically related to images and may contain other metadata.

> +    "short_name": "",
> +    "icons": [
> +        {
> +            "src": "/@@/android-chrome-192x192.png?v=2022",
> +            "sizes": "192x192",
> +            "type": "image/png"
> +        },
> +        {
> +            "src": "/@@/android-chrome-512x512.png?v=2022",
> +            "sizes": "512x512",
> +            "type": "image/png"
> +        }
> +    ],
> +    "theme_color": "#ffffff",
> +    "background_color": "#ffffff",
> +    "display": "standalone"
> +}


-- 
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/423966
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:update-favicon-sizes into launchpad:master.