launchpad-reviewers team mailing list archive

[Guruprasad <mp+423966@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/lib/canonical/launchpad/images/site.webmanifest b/lib/canonical/launchpad/images/site.webmanifest
> new file mode 100644
> index 0000000..6c28a17
> --- /dev/null
> +++ b/lib/canonical/launchpad/images/site.webmanifest
> @@ -0,0 +1,19 @@
> +{
> +    "name": "",

Andrey, thanks for this feedback. I will add the name. 👍

> Also, I'm not sure if the `images` folder is the right place for the manifest file because it isn't specifically related to images and may contain other metadata.

The reasons due to which I put this in the `images` folder are:
* Colin asked me to avoid adding things directly under the root path of the site.
* Purpose of this file atm is related to the favicon images.
* The `images` folder is exposed under `/@@`, so in the browser, it is not explicitly tied to images.

I am not sure if it makes sense to put this elsewhere. Let's wait to hear from Colin as well about this?

> +    "short_name": "",
> +    "icons": [
> +        {
> +            "src": "/@@/android-chrome-192x192.png?v=2022",
> +            "sizes": "192x192",
> +            "type": "image/png"
> +        },
> +        {
> +            "src": "/@@/android-chrome-512x512.png?v=2022",
> +            "sizes": "512x512",
> +            "type": "image/png"
> +        }
> +    ],
> +    "theme_color": "#ffffff",
> +    "background_color": "#ffffff",
> +    "display": "standalone"
> +}


-- 
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/423966
Your team Launchpad code reviewers is requested to review the proposed merge of ~lgp171188/launchpad:update-favicon-sizes into launchpad:master.