libdc1394-dev team mailing list archive

[basarugur <basarugur@xxxxxxxxx>]

Public bug reported:

dc1394_deinterlace_stereo_frames(in, out, method) function contains a
switch with two cases.

however DC1394_INVALID_STEREO_METHOD error is returned once the execution gets out of the switch:
        switch (method) {
        case DC1394_STEREO_METHOD_INTERLACED:
           ...
            break;
        case DC1394_STEREO_METHOD_FIELD:
           ...
          break;
        }
        return DC1394_INVALID_STEREO_METHOD;

 this error should be returned in the "default" section of the switch and DC1394_SUCCESS should be returned when execution gets out of the switch; like:
        switch (method) {
        case DC1394_STEREO_METHOD_INTERLACED:
           ...
            break;
        case DC1394_STEREO_METHOD_FIELD:
           ...
          break;
       default:
        return DC1394_INVALID_STEREO_METHOD;
        }
        return DC1394_SUCCESS;

** Affects: libdc1394
     Importance: Undecided
         Status: New

-- 
dc1394_deinterlace_stereo_frames return wrong value on success
https://bugs.launchpad.net/bugs/360520
You received this bug notification because you are a member of DC1394
Package Mainteners' team, which is subscribed to libdc1394.