linuxdcpp-team team mailing list archive

[maksis <maksis@xxxxxxxxxxxxxxxxxxxxxx>]

Public bug reported:

The encryption is only checked at UserConnectionListener::Connected but
only connections initiated by the other users come there. That setting
has no effect when it's your client that connects to the other user.

Another issue is that DC++ tries to remove the source in the same
location even though there is no user associated to the connection at
that point. Luckily it won't crash the client since
QueueManager::removeSource doesn't have any calls to the member
variables of the user object.

AirDC++ checks the encryption support when receiving a CTM/RCM command,
but also before adding the user as source and before trying to connect
to the user. The code in AirDC++ has been rewritten from those parts so
I'm not able to provide a tested patch.

** Affects: dcplusplus
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of
Dcplusplus-team, which is subscribed to DC++.
https://bugs.launchpad.net/bugs/1206864

Title:
  "Require TLS ADC C-C connections" is broken

Status in DC++:
  New

Bug description:
  The encryption is only checked at UserConnectionListener::Connected
  but only connections initiated by the other users come there. That
  setting has no effect when it's your client that connects to the other
  user.

  Another issue is that DC++ tries to remove the source in the same
  location even though there is no user associated to the connection at
  that point. Luckily it won't crash the client since
  QueueManager::removeSource doesn't have any calls to the member
  variables of the user object.

  AirDC++ checks the encryption support when receiving a CTM/RCM
  command, but also before adding the user as source and before trying
  to connect to the user. The code in AirDC++ has been rewritten from
  those parts so I'm not able to provide a tested patch.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dcplusplus/+bug/1206864/+subscriptions