lubuntu-desktop team mailing list archive

[Martin Bagge / brother <brother@xxxxxxxx>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Sun, 12 Jun 2011, PCMan wrote:

> Hi all,
> I'm here to call for a review for PCManFM as the source code in git is
> in quite good shape now.
> Many known bugs are fixed and I did much refactor to the tabbed
> browsing part and merge changes in tab-rework3 branch with master.
> Please help test and update translations in various distros. If things
> are ok, I propose a new release.

First impressions is that it works fine.
I've built and installed it at Debian Testing.

Three strings in libfm:sc/gtk/fm-side-pane.c was not translatable 
rendering the menu thingie for the side pane (click "places" and you 
should be able to select directory tree (or places if you already had the 
tree showing))
line 49-51
    {"Places", NULL, N_("Places"), NULL, NULL, FM_SP_PLACES},
    {"DirTree", NULL, N_("Directory Tree"), NULL, NULL, FM_SP_DIR_TREE},
    {"Remote", NULL, N_("Remote"), NULL, NULL, FM_SP_REMOTE},

I did translate these strings somewhere but they were not used in this 
particular menu, the view menu works as intended. As well as the labeling.

Screenie:
http://lxde.bsnet.se/~brother/2011-06-libfm_places_menu.png

Also!
It would be a good thing if some native speaker could check the 
strings for both libfm and pcmanfm. I am not a native speaker and I 
haven't read all the strings for a very long time but they probably can be 
improved given that pcman isn't a native speaker either. If you know of 
anyone being able to do this let them/me know.

- -- 
/brother
http://martin.bagge.nu
Bruce Schneier reads RFID cards with the knuckles of his clenched fist.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQEcBAEBCAAGBQJN883SAAoJEJbdSEaj0jV7sT8H/0uqAXhvjrZU1yfVC44LIJdI
4vqkhHq9gxlJLWlOMrKQCfZaocYfR6WafRbc32bcq+IbV1cBXsFMYlTt4BoJY26d
r43gqqJnoI1dVRD11mhxEO3jIGK+yTY+zqhkEOvOKjwc7+0UCz3/0mFDkEmyQiqx
inr4esM27B9ZSj31ope9mA3hdX4tzpuMXhpeNYleAG3QYP5wHfZPSiCsEoMNysOW
l6vjbIM59XHqSJ3h7ii+gTFuPuwH0Fx78v+dqbzHOl6W0Hyvz0e19xJdTnQ5BNHn
8iC4d5votNoAbfcFaqEQyoHYGt1+p6jV3CYmeWgO3nbxpomntXwROvEUY6C9N/o=
=32Bh
-----END PGP SIGNATURE-----