mahara-contributors team mailing list archive

[Richard Mansfield <826453@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

See https://reviews.mahara.org/#change,573

As Brian King noted, there is a bug in the $USER->logout() function that
calls table_exists on a string rather than an XMLDBTable object.

What's worse is that this code in logout() doesn't really serve any
useful purpose.  It is trying to delete a record of the user's session
id when the user logs out, but because most of the time ddl.php is not
included at this point, it won't be triggered.  We should either include
ddl.php explicitly, so it succeeds, or else maybe remove that code
altogether.

** Affects: mahara
     Importance: Low
         Status: Confirmed

** Changed in: mahara
       Status: New => Confirmed

** Changed in: mahara
   Importance: Undecided => Low

** Changed in: mahara
    Milestone: None => 1.5.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/826453

Title:
  Code to delete session id on logout is not triggered

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  See https://reviews.mahara.org/#change,573

  As Brian King noted, there is a bug in the $USER->logout() function
  that calls table_exists on a string rather than an XMLDBTable object.

  What's worse is that this code in logout() doesn't really serve any
  useful purpose.  It is trying to delete a record of the user's session
  id when the user logs out, but because most of the time ddl.php is not
  included at this point, it won't be triggered.  We should either
  include ddl.php explicitly, so it succeeds, or else maybe remove that
  code altogether.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/826453/+subscriptions