mahara-contributors team mailing list archive

[Richard Mansfield <826453@xxxxxxxxxxxxxxxxxx>]

This is not actually fixed, I created this so we don't forget about it
before 1.5.

I merged a commit from Brian King into 1.4, but it needs to be fixed on
master in a different way.  This is the comment from gerrit:

For master I think we should do it differently because currently that
entire if statement is pointless: it's trying to delete a record of the
user's session id from usr_session on logout, but because ddl is almost
never included, it's going to skip it 99% of the time.

** Changed in: mahara
       Status: Fix Committed => Confirmed

** Changed in: mahara
     Assignee: Richard Mansfield (richard-mansfield) => (unassigned)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/826453

Title:
  Code to delete session id on logout is not triggered

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  See https://reviews.mahara.org/#change,573

  As Brian King noted, there is a bug in the $USER->logout() function
  that calls table_exists on a string rather than an XMLDBTable object.

  What's worse is that this code in logout() doesn't really serve any
  useful purpose.  It is trying to delete a record of the user's session
  id when the user logs out, but because most of the time ddl.php is not
  included at this point, it won't be triggered.  We should either
  include ddl.php explicitly, so it succeeds, or else maybe remove that
  code altogether.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/826453/+subscriptions