← Back to team overview

mahara-contributors team mailing list archive

[Bug 837013] [NEW] Incorrect parameter passing between execute_sql_arr and execute_sql

 

Public bug reported:

I'm looking at the very latest 1.3.7 code - not had a chance to look in
1.4.

Looking at the function execute_sql_arr(.....) in dml.php (line 1398 in
mine) it has a parameter called $feedback which is described as 'specify
to show status info (true) or not (false)'.

The function does some stuff and then makes a call to execute_sql( $sql,
$feedback ) noting $feedback as the second parameter (boolean). However,
if you look at execute_sql() (line 135 for me), the second parameter is
called $values and is an array.

** Affects: mahara
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/837013

Title:
  Incorrect parameter passing between execute_sql_arr and execute_sql

Status in Mahara ePortfolio:
  New

Bug description:
  I'm looking at the very latest 1.3.7 code - not had a chance to look
  in 1.4.

  Looking at the function execute_sql_arr(.....) in dml.php (line 1398
  in mine) it has a parameter called $feedback which is described as
  'specify to show status info (true) or not (false)'.

  The function does some stuff and then makes a call to execute_sql(
  $sql, $feedback ) noting $feedback as the second parameter (boolean).
  However, if you look at execute_sql() (line 135 for me), the second
  parameter is called $values and is an array.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/837013/+subscriptions


Follow ups

References