← Back to team overview

maria-developers team mailing list archive

Re: [Commits] Rev 2977: Fix of LP BUG#675248. in file:///home/bell/maria/bzr/work-maria-5.1-lb675248-prep-where/

 

Sanja.

Ok to push after the required changes in comments

Regards,
Igor.

sanja@xxxxxxxxxxxx wrote:
> At file:///home/bell/maria/bzr/work-maria-5.1-lb675248-prep-where/
> 
> ------------------------------------------------------------
> revno: 2977
> revision-id: sanja@xxxxxxxxxxxx-20101123150005-adpcldzod759jgp1
> parent: sanja@xxxxxxxxxxxx-20101118141011-gth6b6pa0w9lyu1b
> committer: sanja@xxxxxxxxxxxx
> branch nick: work-maria-5.1-lb675248-prep-where
> timestamp: Tue 2010-11-23 17:00:05 +0200
> message:
>   Fix of LP BUG#675248.
>   
>   Registration of pointer change if we assign it to other pointer which should be identical after statememnt execution (PS/SP).
> 
    ^fix spelling in the comment
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> commits mailing list
> commits@xxxxxxxxxxx
> https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits

+  /**
+    Assigns new value to place and check item tree changes for need of
+    re-registering the change.

 Make change in item tree after checking whether it needs registering

+
+    @param place         place where we should assign new value
+    @param new_value     place of the new value
+
+    @details
+    see check_and_register_item_tree_change details
+  */
+  void check_and_register_item_tree(Item **place, Item **new_value)
+  {
+    if (!stmt_arena->is_conventional())
+      check_and_register_item_tree_change(place, new_value, mem_root);
+    *place= *new_value;
+  }
   void nocheck_register_item_tree_change(Item **place, Item *old_value,
                                          MEM_ROOT *runtime_memroot);
+  void check_and_register_item_tree_change(Item **place, Item **new_value,
+                                           MEM_ROOT *runtime_memroot);
   void rollback_item_tree_changes();